From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2 2/2] examples: new example: l2fwd-ethtool
Date: Wed, 21 Oct 2015 18:36:12 +0200
Message-ID: <2579237.5XQrXtFRuP@xps13>
References: <1437401571-9104-2-git-send-email-liang-min.wang@intel.com>
 <1437663628-18076-1-git-send-email-liang-min.wang@intel.com>
 <1437663628-18076-3-git-send-email-liang-min.wang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Liang-Min Larry Wang <liang-min.wang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com
 [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id 7FC4AC464
 for <dev@dpdk.org>; Wed, 21 Oct 2015 18:37:17 +0200 (CEST)
Received: by wicll6 with SMTP id ll6so83012547wic.1
 for <dev@dpdk.org>; Wed, 21 Oct 2015 09:37:17 -0700 (PDT)
In-Reply-To: <1437663628-18076-3-git-send-email-liang-min.wang@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-07-23 11:00, Liang-Min Larry Wang:
>  examples/Makefile                                |    1 +
>  examples/l2fwd-ethtool/Makefile                  |   48 +
>  examples/l2fwd-ethtool/l2fwd-app/Makefile        |   58 ++
>  examples/l2fwd-ethtool/l2fwd-app/main.c          | 1025 ++++++++++++++++++++++
>  examples/l2fwd-ethtool/l2fwd-app/netdev_api.h    |  770 ++++++++++++++++
>  examples/l2fwd-ethtool/l2fwd-app/shared_fifo.h   |  159 ++++
>  examples/l2fwd-ethtool/lib/Makefile              |   57 ++
>  examples/l2fwd-ethtool/lib/rte_ethtool.c         |  336 +++++++
>  examples/l2fwd-ethtool/lib/rte_ethtool.h         |  385 ++++++++
>  examples/l2fwd-ethtool/nic-control/Makefile      |   55 ++
>  examples/l2fwd-ethtool/nic-control/nic_control.c |  614 +++++++++++++
>  11 files changed, 3508 insertions(+)

This patch is huge.
Please split a bit.

> --- a/examples/Makefile
> +++ b/examples/Makefile
> @@ -53,6 +53,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_KNI) += kni
>  DIRS-y += l2fwd
>  DIRS-$(CONFIG_RTE_LIBRTE_IVSHMEM) += l2fwd-ivshmem
>  DIRS-$(CONFIG_RTE_LIBRTE_JOBSTATS) += l2fwd-jobstats
> +DIRS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += l2fwd-ethtool
>  DIRS-y += l3fwd

Please keep the alphabetical order.

I do not plan to review it more.
If nobody complains, it means it's accepted.