From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 1/2] Remove ABI requierment for external library builds. Date: Wed, 21 Oct 2015 18:31:33 +0200 Message-ID: <2583772.E1h0hm0DcT@xps13> References: <1437401571-9104-2-git-send-email-liang-min.wang@intel.com> <1437663628-18076-1-git-send-email-liang-min.wang@intel.com> <1437663628-18076-2-git-send-email-liang-min.wang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Liang-Min Larry Wang Return-path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id DCD6C9432 for ; Wed, 21 Oct 2015 18:32:38 +0200 (CEST) Received: by wicll6 with SMTP id ll6so99213330wic.0 for ; Wed, 21 Oct 2015 09:32:38 -0700 (PDT) In-Reply-To: <1437663628-18076-2-git-send-email-liang-min.wang@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-07-23 11:00, Liang-Min Larry Wang: > From: "Andrew G. Harvey" > --- a/mk/rte.extlib.mk > +++ b/mk/rte.extlib.mk > @@ -31,6 +31,8 @@ > > MAKEFLAGS += --no-print-directory > > +export EXTLIB_BUILD := 1 Is export really needed? Except that, this patch looks OK.