From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] eal: fslmc bus need vfio enabled for non PCI case as well Date: Fri, 06 Oct 2017 01:41:01 +0200 Message-ID: <2584395.73f1Oakct5@xps> References: <1499946530-29581-1-git-send-email-hemant.agrawal@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Hemant Agrawal , anatoly.burakov@intel.com Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 0E8B71B1BC for ; Fri, 6 Oct 2017 01:41:03 +0200 (CEST) In-Reply-To: <1499946530-29581-1-git-send-email-hemant.agrawal@nxp.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/07/2017 13:48, Hemant Agrawal: > In case no_pci is configured, fslmc bus will still need the > the vfio to be enabled. > > Signed-off-by: Hemant Agrawal > --- > --- a/lib/librte_eal/linuxapp/eal/eal.c > +++ b/lib/librte_eal/linuxapp/eal/eal.c > +#ifdef RTE_LIBRTE_FSLMC_BUS > + if (!vfio_enabled) { > + if (!vfio_enable("vfio_fsl_mc")) > + vfio_enabled = 1; > + } > +#endif It seems to be a hack. VFIO is not only PCI. Why --no-pci is impacting VFIO? Anatoly?