From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] lcore: make semantics of lcore role function more intuitive Date: Thu, 26 Apr 2018 16:30:42 +0200 Message-ID: <2584582.pWCQVUZt55@xps> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Neil Horman , John McNamara , Marko Kovacevic , Robert Sanford , erik.g.carrillo@intel.com, olivier.matz@6wind.com, shreyansh.jain@nxp.com To: Anatoly Burakov Return-path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id F39158D9C for ; Thu, 26 Apr 2018 16:30:44 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 26/04/2018 15:42, Anatoly Burakov: > rte_lcore_has_role() returns 0 if role of lcore matches requested > role. The return value of the API is confusing, and this is a known > problem with a deprecation notice announcing the change to more > intuitive semantics: > > Commit 064518f68d48 ("doc: announce EAL API change to lcore role function") > Cc: erik.g.carrillo@intel.com > > Implement changes announced in the deprecation notice, and remove it. > Also, fix usages of this API to reflect the change. Control thread patches > expected new behavior and were broken before, now they are fixed as well. > > Fixes: d651ee4919cd ("eal: set affinity for control threads") > Cc: olivier.matz@6wind.com > > Signed-off-by: Anatoly Burakov Applied, thanks