From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] PCAP PMD fix: pcap_rx_queue/pcap_tx_queue should store it's own copy of name/type values Date: Tue, 12 May 2015 12:30:37 +0200 Message-ID: <2589343.PLMJveI5zI@xps13> References: <1429799568-19899-1-git-send-email-konstantin.ananyev@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Ananyev, Konstantin" Return-path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by dpdk.org (Postfix) with ESMTP id 8E2D2376C for ; Tue, 12 May 2015 12:31:22 +0200 (CEST) Received: by wicnf17 with SMTP id nf17so8707166wic.1 for ; Tue, 12 May 2015 03:31:19 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > pcap_rx_queue/pcap_tx_queue should store it's own copy of name/type > > values, not the pointer to temporary allocated space. > > > > Signed-off-by: Konstantin Ananyev > > Acked-by: John Mcnamara Applied, thanks Please note the new name for this commit: pcap: fix storage of name and type in queues It begins with the lowercase name of the PMD, then a verb in imperative form and a short summary. The verb should be "fix" in case of fixes. Ideally, the bug (and its consequences) should be explained below. https://github.com/erlang/otp/wiki/Writing-good-commit-messages