From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] ethdev: Clarify usage of TM node parent
	update API function
Date: Tue, 31 Jul 2018 18:52:02 +0200
Message-ID: <2590450.z5BpaqTJhJ@xps>
References: <20180710153301.546-1-benjamin.h.shelton@intel.com>
 <1748890.xKDDESA46q@xps>
 <3EB4FA525960D640B5BDFFD6A3D891268E77C744@IRSMSX107.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: "Shelton, Benjamin H" <benjamin.h.shelton@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id AB4B4378E
 for <dev@dpdk.org>; Tue, 31 Jul 2018 18:52:08 +0200 (CEST)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891268E77C744@IRSMSX107.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

31/07/2018 17:09, Dumitrescu, Cristian:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 
> > Cristian, review please?
> > 
> > 10/07/2018 17:33, Ben Shelton:
> > > The node parent update API function may be used to update the
> > > priority/weight of an existing node.  Update the documentation to
> > > indicate that this use case is supported.
> > >
> > > Signed-off-by: Ben Shelton <benjamin.h.shelton@intel.com>
> > [...]
> > >  /**
> > >   * Traffic manager node parent update
> > >   *
> > > + * This function may be used to move a node and its children to a
> > different
> > > + * parent.  Additionally, if the new parent is the same as the current
> > parent,
> > > + * this function will update the priority/weight of an existing node.
> > > + *
> > >   * Restriction for root node: its parent cannot be changed.
> > >   *
> > >   * This function can only be called after the rte_tm_hierarchy_commit()
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks