From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2 0/4] vhost: Fix virtio-net on
	VHOST_USER_RESET_OWNER
Date: Wed, 21 Oct 2015 12:26:26 +0200
Message-ID: <2592854.UTMZLixLNt@xps13>
References: <1445247869-713-1-git-send-email-jerome.jutteau@outscale.com>
 <20151020082550.GY3115@yliu-dev.sh.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Jerome Jutteau <jerome.jutteau@outscale.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com
 [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id 4100293F8
 for <dev@dpdk.org>; Wed, 21 Oct 2015 12:27:32 +0200 (CEST)
Received: by wicfv8 with SMTP id fv8so67934726wic.0
 for <dev@dpdk.org>; Wed, 21 Oct 2015 03:27:32 -0700 (PDT)
In-Reply-To: <20151020082550.GY3115@yliu-dev.sh.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> > I have a bug when Qemu with two vhost interfaces gently stops (SIGINT).
> > When stopping, it sends two RESET_OWNER for each interface:
> > - Before stopping, we have two interfaces identifers: 0 and 1.
> > - The first reset_owner call resets device 1 (and this id device_fh) to zero,
> >   the device list now contains two devices with id 0.
> > - The second call don't find device 1 and segfault as reset_owner don't
> >   check if the device has been found or not.
> > - Later, user_get_vring_base can also segfault for the same reason.
> > 
> > This series of patches propose to fix the way reset_owner alter a device and
> > add more checks when searching for a device.
> > 
> > In this v2, we use get_device instead of get_config_ll_entry to get an error
> > message when a device is not found.
> > 
> > Jerome Jutteau (4):
> >   vhost: avoid device identifier to be reset to 0 in reset_owner
> >   vhost: check that a device exists during reset_owner
> >   vhost: protect user_get_vring_base from unknown devices
> >   vhost: change method to get device in reset_owner
> 
> Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>

Applied, thanks