From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] app/testpmd: fix failsafe PMD failure on exit Date: Tue, 22 May 2018 21:49:37 +0100 Message-ID: <25f03156-00a7-28ee-9519-6cb4262a83f7@intel.com> References: <20180522183509.66644-1-ferruh.yigit@intel.com> <5833665.TREZe9cROF@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Wenzhuo Lu , Jingjing Wu , dev@dpdk.org, Zhiyong Yang , Bernard Iremonger To: Thomas Monjalon Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 842E111D4 for ; Tue, 22 May 2018 22:49:40 +0200 (CEST) In-Reply-To: <5833665.TREZe9cROF@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/22/2018 8:47 PM, Thomas Monjalon wrote: > 22/05/2018 20:35, Ferruh Yigit: >> vdevs detach on testpmd exit implemented as workaround to fix >> a virtio-user issue. The issue was virtio-user cleanup is not >> called and existing socket file not cleaned up which will fail >> next run. >> >> The vdev cleanup causing problems in failsafe PMD. >> >> Reduce the cleanup to only virtio-user and add a comment that this >> workaround should be converted to a proper cleanup, not something >> specific to virtio-user, and not something specific to vdev and >> testpmd. >> >> Fixes: fe890955114d ("app/testpmd: fix exit for vdevs") >> >> Signed-off-by: Ferruh Yigit > > OK to squash it with above patch. Squashed into relevant commit in next-net, thanks. > Thanks for the update. > > Note: this patch is not related to failsafe. > There was a deadlock introduced in 18.05-rc1 when detaching failsafe, > but it is fixed by using a recursive lock in vdev. Thanks for the clarification, I mixed the issues.