From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH 5/6] testpmd: show topology at forwarding
	start
Date: Wed, 25 May 2016 11:45:19 +0200
Message-ID: <2604231.jECmEcnI7g@xps13>
References: <1462488421-118990-1-git-send-email-zhihong.wang@intel.com>
 <1462488421-118990-6-git-send-email-zhihong.wang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, konstantin.ananyev@intel.com, bruce.richardson@intel.com,
 pablo.de.lara.guarch@intel.com
To: Zhihong Wang <zhihong.wang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id C950D37B0
 for <dev@dpdk.org>; Wed, 25 May 2016 11:45:20 +0200 (CEST)
Received: by mail-wm0-f43.google.com with SMTP id n129so172042630wmn.1
 for <dev@dpdk.org>; Wed, 25 May 2016 02:45:20 -0700 (PDT)
In-Reply-To: <1462488421-118990-6-git-send-email-zhihong.wang@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-05-05 18:47, Zhihong Wang:
> This patch show topology at forwarding start.
> 
> "show config fwd" also does this, but showing it directly can reduce the
> possibility of misconfiguration.
[...]
> -	fwd_config_setup();
> +	fwd_config_display();
>  	rxtx_config_display();

Having _display() calling _setup() is really strange.
Maybe it is worth to be fixed in this patch.