From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v4 04/41] bus/dpaa: add OF parser for device scanning Date: Tue, 19 Sep 2017 22:01:23 +0200 Message-ID: <2610477.kMnjFRTE32@xps> References: <20170823141213.25476-1-shreyansh.jain@nxp.com> <9142ad53-f75b-de33-cb8d-51ae5a781a2e@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, hemant.agrawal@nxp.com, Jan Viktorin To: Ferruh Yigit , Shreyansh Jain Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 5ECA816E for ; Tue, 19 Sep 2017 22:01:25 +0200 (CEST) In-Reply-To: <9142ad53-f75b-de33-cb8d-51ae5a781a2e@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/09/2017 16:15, Ferruh Yigit: > On 9/19/2017 2:37 PM, Shreyansh Jain wrote: > > On Monday 18 September 2017 08:19 PM, Ferruh Yigit wrote: > >> On 9/9/2017 12:20 PM, Shreyansh Jain wrote: > >>> This layer is used by Bus driver's scan function. Devices are parsed > >>> using OF parser and added to DPAA device list. > >> > >> So this is device tree parser in DPDK. Do we really want this, and as > >> long as DPDK target the bare metal why not get device information from > >> Linux, as done in other cases? > > As of now I don't prefer to modify the internal framework as much as > > possible as this is stable DPDK DPAA driver. > > There is indeed a planned transition from OF to /sys/ parsing, but it is > > still in pipeline. > > > > You see a blocking issue if we go incremental here? > > That would be probably more of replacing this file with another /sys > > parser without much changes to the DPDK glue code. > > OF parser in DPDK looks weird to me, OS will do this for us already. > > If replacing this is in the roadmap, I think this is not showstopper, > added Thomas in case he thinks otherwise. I agree with Ferruh. I am interested to know if there are cases where a device tree parser would be relevant in DPDK. Cc Jan who already worked on this idea.