From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] ixgbe:Prevent redefinition of bool if
	compiling using c++
Date: Mon, 18 Jul 2016 17:13:13 +0200
Message-ID: <2620065.kVZaRD93r7@xps13>
References: <20160718133630.58012-1-ibarnea@cisco.com>
 <24085954.MYZGtIaJgz@xps13> <50DD7300-C300-4862-AEDB-B148206013AD@cisco.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Helin Zhang <helin.zhang@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>
To: "Ido Barnea (ibarnea)" <ibarnea@cisco.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 23752CE7
 for <dev@dpdk.org>; Mon, 18 Jul 2016 17:13:15 +0200 (CEST)
Received: by mail-wm0-f46.google.com with SMTP id q128so12138835wma.1
 for <dev@dpdk.org>; Mon, 18 Jul 2016 08:13:15 -0700 (PDT)
In-Reply-To: <50DD7300-C300-4862-AEDB-B148206013AD@cisco.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-07-18 14:12, Ido Barnea:
> In Trex, we do include ixgbe_type.h from c++ code because we do some
> register writes ourselves to support some functionality not exposed in
> the DPDK API.

I agree we should find a way to expose some driver-specific headers for
very specific features which will never be implemented elsewhere.
But ideally, we should try to fix the DPDK API.

> We can continue making this change in our copy of the code only. Just 
> trying to align our code with the official version as much as possible,
> and thought it might benefit others as well to make this c++ compatible. 
> Apart from this small change, c++ compilation is supported.

OK. Other comment from the maintainers (cc) of this driver?


PS: please avoid top-post.


> On 18/07/2016, 4:54 PM, "Thomas Monjalon" <thomas.monjalon@6wind.com> wrote:
> 
> >Hi,
> >
> >DPDK is a C code and do not support C++ compilation.
> >Only the exposed headers have some C++ support requirements.
> >
> >>  drivers/net/ixgbe/base/ixgbe_osdep.h | 2 ++
> >
> >Patching this file for C++ will be probably rejected, sorry.
> >
> >I'm interested to understand what is your need?