From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 11/29] eal: generic implementation for I/O device read/write access Date: Sun, 15 Jan 2017 22:29:42 +0100 Message-ID: <2622450.7mMCSCBjjk@xps13> References: <1482832175-27199-1-git-send-email-jerin.jacob@caviumnetworks.com> <1484212646-10338-1-git-send-email-jerin.jacob@caviumnetworks.com> <1484212646-10338-12-git-send-email-jerin.jacob@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, konstantin.ananyev@intel.com, bruce.richardson@intel.com, jianbo.liu@linaro.org, viktorin@rehivetech.com, santosh.shukla@caviumnetworks.com To: Jerin Jacob Return-path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id C6159F977 for ; Sun, 15 Jan 2017 22:29:44 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id c85so135173826wmi.1 for ; Sun, 15 Jan 2017 13:29:44 -0800 (PST) In-Reply-To: <1484212646-10338-12-git-send-email-jerin.jacob@caviumnetworks.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-01-12 14:47, Jerin Jacob: > +#define rte_read8_relaxed(addr) \ > + ({ uint8_t __v = *(const volatile uint8_t *)addr; __v; }) Why do you prefer a macro over an inline function? It won't provide the same "debuggability".