From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] eal/bsdapp: don't clean up files at startup Date: Mon, 14 Jan 2019 15:22:56 +0100 Message-ID: <26237186.kTPCeHV27o@xps> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Bruce Richardson , stable@dpdk.org To: Anatoly Burakov Return-path: In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/01/2019 12:34, Anatoly Burakov: > On FreeBSD, closing the file descriptor drops the lock even if the > file descriptor was mmap'ed. This leads to the cleanup at the end > of EAL init to remove fbarray files that are still in use by the > process itself. > > However, instead of working around this issue, we can take advantage > of the fact that FreeBSD doesn't really create any per-process > files in the first place, so no cleanup is actually needed. > > Fixes: 0a529578f162 ("eal: clean up unused files on initialization") > Cc: stable@dpdk.org > > Signed-off-by: Anatoly Burakov Applied, thanks