From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] eal: move compat includes to common meson file Date: Thu, 10 Jan 2019 09:52:43 +0100 Message-ID: <2632071.H5f8aPozaM@xps> References: <98ec658513d481f8d22c8b438cc3fedc4a718d3f.1547054251.git.anatoly.burakov@intel.com> <1557339.2CBSiR8abE@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Bruce Richardson , David Marchand , dev@dpdk.org To: "Burakov, Anatoly" Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 0D7AF1B59E for ; Thu, 10 Jan 2019 09:52:47 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/01/2019 09:45, Burakov, Anatoly: > On 09-Jan-19 9:36 PM, Thomas Monjalon wrote: > > 09/01/2019 21:51, Bruce Richardson: > >> On Wed, Jan 09, 2019 at 06:29:32PM +0100, David Marchand wrote: > >>> On Wed, Jan 9, 2019 at 6:18 PM Anatoly Burakov > >>> <[1]anatoly.burakov@intel.com> wrote: > >>> > >>> Currently, while EAL does depend on librte_compat as far as common > >>> meson build is concerned, for some reason the headers for that > >>> library are not added into the list of includes. This is fixed in > >>> Linuxapp-specific meson file, but is absent from FreeBSD meson file. > >>> This worked fine up until recently, when an rte_compat dependency > >>> was added to rte_log, which is a common header. Fix this issue by > >>> adding librte_compat includes to common EAL meson file. > >>> Fixes: 844514c73569 ("eal: build with meson") > >>> Fixes: a8499f65a1d1 ("log: add missing experimental tag") > >>> Cc: [2]bruce.richardson@intel.com > >>> Cc: [3]david.marchand@redhat.com > >>> Cc: [4]stable@dpdk.org > >>> Signed-off-by: Anatoly Burakov <[5]anatoly.burakov@intel.com> > >>> > >>> lgtm, thanks. > >>> Reviewed-by: David Marchand <[6]david.marchand@redhat.com> > >>> -- > >>> David Marchand > >>> > >> Agreed. > >> One other point I'd make is that having compat as a separate library seems > >> a little like overkill to me - it's just one header file! Is there a reason > >> why we don't just move it into the EAL where everyone can use it without > >> having to specify another dependency? > > > > +1 for moving compat into EAL. > > > > Presumably the reason to keep it separate would be to enable depending > on it for libraries that EAL itself depends on (i.e. kvargs). Yes, forgot this one.