From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 0/3] Rename field name for RX/TX queue start/stop Date: Tue, 22 Jul 2014 11:37:48 +0200 Message-ID: <2633548.rrHgnQHcZ9@xps13> References: <1406015252-27804-1-git-send-email-changchun.ouyang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Ouyang Changchun Return-path: In-Reply-To: <1406015252-27804-1-git-send-email-changchun.ouyang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi, 2014-07-22 15:47, Ouyang Changchun: > This patch series include 3 things: > 1) Rename the field name from start_rx_per_q to rx_enable_queue in > struct rte_eth_rxconf, and do same thing for TX. > This patch also update description for field rx_enable_queue and tx_enable_queue. > 2) According to 1), update field name from start_rx_per_q to rx_enable_queue in struct igb_rx_queue > in ixgbe PMD, do same thing for TX. > 3) Update its reference in sample vhost. In order to be atomic (and do not break git bisect), you should submit it in one patch. Title would be "ethdev: rename queue enabler field" or something like that. But the most important in such change is to explain why you make it. Thanks -- Thomas