From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 2/4] doc: rendering and installation of man pages Date: Wed, 26 Oct 2016 23:13:08 +0200 Message-ID: <26384999.AQX2uQSfKq@xps13> References: <1472629812-4397-1-git-send-email-christian.ehrhardt@canonical.com> <1472629812-4397-3-git-send-email-christian.ehrhardt@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Christian Ehrhardt Return-path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 30E4EBB48 for ; Wed, 26 Oct 2016 23:13:10 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id e69so58534584wmg.0 for ; Wed, 26 Oct 2016 14:13:10 -0700 (PDT) In-Reply-To: <1472629812-4397-3-git-send-email-christian.ehrhardt@canonical.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-08-31 09:50, Christian Ehrhardt: > +ifneq ($(wildcard $O/doc/man/*/*.1),) > + $(Q)$(call rte_mkdir, $(DESTDIR)$(mandir)) This line is useless because implicit in the next one. > + $(Q)$(call rte_mkdir, $(DESTDIR)$(mandir)/man1) > + $(Q)cp -a $O/doc/man/*/*.1 $(DESTDIR)$(mandir)/man1 > +endif There is also a small alignment issue.