From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v5 2/8] eal: add header files to support windows Date: Wed, 27 Mar 2019 23:29:10 +0100 Message-ID: <2640699.3m2PSFbs9Z@xps> References: <20190306041634.12976-1-anand.rawat@intel.com> <944cfe276e570e3e6feb01a7da7c6fa03de22ee4.camel@marvell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: "anand.rawat@intel.com" , "dev@dpdk.org" , "pallavi.kadam@intel.com" , "jeffrey.b.shaw@intel.com" , "bruce.richardson@intel.com" To: Ranjit Menon , Jerin Jacob Kollanukkaran Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id DD4684F90 for ; Wed, 27 Mar 2019 23:29:14 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/03/2019 22:23, Ranjit Menon: > On 3/26/2019 3:20 AM, Jerin Jacob Kollanukkaran wrote: > > On Mon, 2019-03-25 at 23:02 -0700, Anand Rawat wrote: > >> Added header files to support windows on x86 platforms. > >> Updated rte_common.h to include rte_windows.h for windows > >> build. Updated lib/meson.build to create shared libraries > >> on windows. Added def file to list the exports for the > >> eal library. > >> > >> Signed-off-by: Anand Rawat > >> Signed-off-by: Pallavi Kadam > >> Signed-off-by: Bruce Richardson > >> Reviewed-by: Jeff Shaw > >> Reviewed-by: Ranjit Menon > >> --- > >> lib/librte_eal/common/include/rte_common.h | 7 ++++- > >> .../common/include/rte_string_fns.h | 4 ++- > >> lib/librte_eal/rte_eal_exports.def | 9 ++++++ > >> .../windows/eal/include/rte_windows.h | 30 > >> +++++++++++++++++++ > >> lib/librte_eal/windows/eal/meson.build | 2 ++ > >> lib/meson.build | 19 ++++++++++-- > >> 6 files changed, 66 insertions(+), 5 deletions(-) > >> create mode 100644 lib/librte_eal/rte_eal_exports.def > >> create mode 100644 lib/librte_eal/windows/eal/include/rte_windows.h > >> > >> diff --git a/lib/librte_eal/common/include/rte_common.h > >> b/lib/librte_eal/common/include/rte_common.h > >> index 7178ba1e9..4775c84f5 100644 > >> --- a/lib/librte_eal/common/include/rte_common.h > >> +++ b/lib/librte_eal/common/include/rte_common.h > >> @@ -1,5 +1,5 @@ > >> /* SPDX-License-Identifier: BSD-3-Clause > >> - * Copyright(c) 2010-2014 Intel Corporation > >> + * Copyright(c) 2010-2019 Intel Corporation > >> */ > >> > >> #ifndef _RTE_COMMON_H_ > >> @@ -24,6 +24,11 @@ extern "C" { > >> > >> #include > >> > >> +/* windows specific*/ > >> +#ifdef RTE_EXEC_ENV_WINDOWS > >> +#include > >> +#endif > >> + > > > > IMO, Updating the rte_common.h for each execution environment is not > > clean and unnecessary #ifdef clutter in the common code. > > > > I think, it can be fixed by adding new os or eal specific header file > > at the following location and simply include it(without any #ifdef) > > > > lib/librte_eal/linux/eal/include/exec-env/rte_eal.h > > lib/librte_eal/freebsd/eal/include/exec-env/rte_eal.h > > lib/librte_eal/windows/eal/include/exec-env/rte_eal.h # the content of > > exiting rte_windows.h goes here. > > > > It can be rte_eal.h or rte_os.h or anything similar. > > > > > This was done based on a suggestion from Thomas: > (http://patches.dpdk.org/patch/50844/) > > But, I agree. Your suggestion would be a good enhancement. There is > already an existing rte_eal.h in common/include, so an rte_os.h or > something similar might make sense. Yes I agree with rte_os.h