From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] build: set CFLAGS for ppc64el build Date: Tue, 16 Feb 2016 19:09:22 +0100 Message-ID: <2641339.7y4mNALekD@xps13> References: <1455296713-7417-1-git-send-email-ferseiti@linux.vnet.ibm.com> <56BE3015.7090804@linux.vnet.ibm.com> <56C364A4.3010000@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Fernando Seiti Furusato Return-path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id DFA34C130 for ; Tue, 16 Feb 2016 19:10:54 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id g62so121479572wme.1 for ; Tue, 16 Feb 2016 10:10:54 -0800 (PST) In-Reply-To: <56C364A4.3010000@linux.vnet.ibm.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-02-16 16:04, Fernando Seiti Furusato: > Hi Thomas. > > On 02/12/2016 05:18 PM, Fernando Seiti Furusato wrote: > > Hello Thomas. > > Thanks for your quick response. > > > > On 02/12/2016 03:37 PM, Thomas Monjalon wrote: > >> 2016-02-12 12:05, Fernando Seiti Furusato: > >>> Add a proper ifeq statement to set the mcpu as needed for ppc64el, as > >>> the only one originally set is not valid for ppc architectures. > >> > >> What is the benefit of using the default machine config, compared to > >> the power8 one? > >> > >> Don't you think the default machine should be renamed core2? > > > > I think it would be better indeed. Thanks for pointing that out. > > > >> > >> [...] > >>> +ifeq (ppc64le,$(shell uname -m)) > >>> + MACHINE_CFLAGS += -mcpu=power8 > >> > >> Why this flag is not set in mk/machine/power8/rte.vars.mk ? > >> > > > > This and what observed above would make a better patch. > > Let me try those. > > I will be just changing the flag within mk/machine/power8/rte.vars.mk so > it will be used on ppc64le. Does it mean that only little endian is supported on POWER8? > I thought since I am not sure how it will affect others, I will not mess > with the default file. Yes let's keep it for another patch if someone is concerned. > I had to copy config/defconfig_ppc_64-power8-linuxapp-gcc to > config/defconfig_ppc64le-native-linuxapp-gcc, because the build searches > for it on ppc64le. Should I include that in the patch? > Do you think there is a better approach? Not sure to understand. I think there is something wrong in the commands you use to compile. Are you using "make config T=ppc_64-power8-linuxapp-gcc" ?