From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] meson: fix compilation with binutils version
	2.30
Date: Thu, 17 Jan 2019 19:23:08 +0100
Message-ID: <2654509.CpMWhpLgrV@xps>
References: <20190117171744.63455-1-harry.van.haaren@intel.com>
 <884f29ec-a85d-41f2-abd7-17b5bbeea3bb@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
 bruce.richardson@intel.com
To: Harry van Haaren <harry.van.haaren@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com
 [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 585672BA3
 for <dev@dpdk.org>; Thu, 17 Jan 2019 19:23:12 +0100 (CET)
In-Reply-To: <884f29ec-a85d-41f2-abd7-17b5bbeea3bb@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

17/01/2019 18:23, Ferruh Yigit:
> On 1/17/2019 5:17 PM, Harry van Haaren wrote:
> > This commit reworks the checks for binutils 2.30 and how
> > the flags to disable AVX512F are passed to the compiler.
> > 
> > Previously the #define for including AVX512 code was set,
> > while the -mno-avx512f argument was given to the compiler.
> > This would cause gcc to correctly refuse to emit AVX512
> > instructions, but the rte_memcpy code that includes AVX512
> > optimizations was being added to the build.
> > 
> > The check for binutils check is now moved to x86 as it is
> > irrelevant for other architectures, and the -mno-avx512f
> > flag is passed to a march_opts array in meson. As the
> > -mno-avx512 flag is added earlier in the build, the code
> > in rte_memcpy is no longer attempted to be compiled.
> > 
> > This commit also adds a message print in the meson configure
> > stage to alert the user of the workaround being employed.
> > 
> > Fixes: a32ca9a4ebc1 ("mk: fix scope of disabling AVX512F support")
> > 
> > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> 
> Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Thanks for the fix Harry.

Applied (with message reworded as suggested), thanks