From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2 4/4] devtools: add autotest app to build
	script
Date: Thu, 30 Mar 2017 22:42:03 +0200
Message-ID: <2656152.ADfflcFtbm@xps13>
References: <20170329140419.27149-1-bruce.richardson@intel.com>
 <1851186.Q5rVaVkRzi@xps13>
 <20170330153322.GB14552@bricha3-MOBL3.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: pablo.de.lara.guarch@intel.com, dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>, ferruh.yigit@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com
 [209.85.128.180]) by dpdk.org (Postfix) with ESMTP id 915ED271
 for <dev@dpdk.org>; Thu, 30 Mar 2017 22:42:05 +0200 (CEST)
Received: by mail-wr0-f180.google.com with SMTP id w11so76451310wrc.3
 for <dev@dpdk.org>; Thu, 30 Mar 2017 13:42:05 -0700 (PDT)
In-Reply-To: <20170330153322.GB14552@bricha3-MOBL3.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

For info, Ferruh did a similar patch:
	http://dpdk.org/patch/22443
Ferruh, OK to keep Bruce one?

2017-03-30 16:33, Bruce Richardson:
> On Thu, Mar 30, 2017 at 04:36:11PM +0200, Thomas Monjalon wrote:
> > 2017-03-29 17:38, Bruce Richardson:
> > > Since the test app is no longer being build by default as part of a build,
> > > we need to update the testbuild script to take account of this.
> > [...]
> > > --- a/devtools/test-build.sh
> > > +++ b/devtools/test-build.sh
> > > @@ -229,6 +229,9 @@ for conf in $configs ; do
> > >  	echo "================== Build $dir"
> > >  	make -j$J EXTRA_CFLAGS="$maxerr $DPDK_DEP_CFLAGS" \
> > >  		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir
> > > +	echo "================== Build tests for $dir"
> > > +	make test-build -j$J EXTRA_CFLAGS="$maxerr $DPDK_DEP_CFLAGS" \
> > > +		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose O=$dir
> > >  	! $short || break
> > >  	echo "================== Build examples for $dir"
> > >  	export RTE_SDK=$(pwd)
> > 
> > It should be added after the "short break".
> > 
> You have no idea how many times in preparing the patchset I moved the
> addition above the break, and then back below it, and above it again!
> You pick what you think is best. :-)
> 
> > The test-build target rebuild all.
> It rebuilds the libs, but not the apps, which is why we can't just
> use test-build target, or we will skip testpmd.
> 
> > I think it should be standard apps like the examples
> > and not re-link the libs before building.
> > The other way is to merge it with the above command (default build).
> 
> I tried merging the two into a single command, i.e. "make all
> test-build" but that failed with parallel builds because the two jobs
> try and build some things at the same time and interfere with each
> other. [The kernel drivers seemed to be the main problem]
> 
> /Bruce