From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] librte_ether: use RTE_ETH_VALID_PORTID_OR_ERR_RET to check port_id Date: Fri, 13 May 2016 18:20:31 +0200 Message-ID: <2661729.DcqZie9VKo@xps13> References: <1461943396-7094-1-git-send-email-mauricio.vasquezbernal@studenti.polito.it> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Mauricio Vasquez B Return-path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 049E095D1 for ; Fri, 13 May 2016 18:20:34 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id n129so28960001wmn.1 for ; Fri, 13 May 2016 09:20:33 -0700 (PDT) In-Reply-To: <1461943396-7094-1-git-send-email-mauricio.vasquezbernal@studenti.polito.it> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-04-29 17:23, Mauricio Vasquez B: > The RTE_ETH_VALID_PORTID_OR_ERR_RET macro is used in some places > to check if a port id is valid or not. This commit makes use of it in > some new parts of the code. There are other occurences: rte_eth_dev_socket_id rte_eth_add_rx_callback rte_eth_add_tx_callback rte_eth_remove_rx_callback rte_eth_remove_tx_callback I think it could be done also in examples/ethtool/lib.