From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v5 05/10] qede: Add core driver Date: Wed, 20 Apr 2016 10:54:51 +0200 Message-ID: <2663604.CUOUCMLdhT@xps13> References: <1459476927-21387-1-git-send-email-rasesh.mody@qlogic.com> <11002101.xZ8QHIe3Y4@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: bruce.richardson@intel.com, dev@dpdk.org, stephen@networkplumber.org, Ameen Rahman , Harish Patil , Sony Chacko To: Rasesh Mody Return-path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id AF2733B5 for ; Wed, 20 Apr 2016 10:54:53 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id l6so33367600wml.1 for ; Wed, 20 Apr 2016 01:54:53 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-04-20 01:09, Rasesh Mody: > Hi Thomas, > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Tuesday, April 19, 2016 5:59 AM > > > > 2016-03-31 19:15, Rasesh Mody: > > > +ifeq ($(OS_TYPE),Linux) > > > +CFLAGS_ECORE_DRIVER += -Wno-shift-negative-value endif > > > > I see an error with clang: > > fatal error: unknown warning option '-Wno-shift-negative-value'; > > did you mean '-Wno-shift-sign-overflow'? > > We had compiled all our v5 driver patches against clang v3.8 on RH7.1 and didn't see a similar error. > "clang version 3.8.0 (trunk 249596) (llvm/trunk 249595)" > > The '-Wno-shift-negative-value' option only got introduced after 3.6.0 clang release. Pls. let us know if we need to support a minimum version of clang. We had asked this question earlier in the dpdk community, however we didn't hear back from anyone so far. I use clang-3.6.2. You are right there is no official requirement in doc/guides/linux_gsg/sys_reqs.rst. Opinions about minimal version to support?