From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] enicpmd: compilation error during inclusion of vfio.h Date: Fri, 28 Nov 2014 15:16:22 +0100 Message-ID: <2664831.CNeh3do0yF@xps13> References: <1417108480-28341-1-git-send-email-ssujith@cisco.com> <533710CFB86FA344BFBF2D6802E60286C9B11F@SHSMSX101.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Qiu, Michael" Return-path: In-Reply-To: <533710CFB86FA344BFBF2D6802E60286C9B11F-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-11-28 02:09, Qiu, Michael: > I have no comments on this issue, but I indeed see many places do have > this kernel issue(before/now/future), so can solve this issue globally? > > Thus, we do not need to fix this case by case. > > One solution(not sure if it works or not): > > 1. features and kernel version required list. > 2. When config DPDK before build, automatically check this list and if > not mach, just disable this feature in config file even though user set > it manually. > > Thus main code may not need to change. > > Does this works? If configuration system was different, we could have a list of constraint to satisfy before enabling a feature. -- Thomas