From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH FIX-OPTION-1] mbuf: fix the logic of user mempool ops API Date: Tue, 06 Feb 2018 01:05:19 +0100 Message-ID: <26657316.2WP0XlBasG@xps> References: <1517514427-28843-1-git-send-email-hemant.agrawal@nxp.com> <1517558582-27108-2-git-send-email-hemant.agrawal@nxp.com> <20180202134007.qvip4jkiv2gksxoj@platinum> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Olivier Matz , pbhagavatula@caviumnetworks.com, nipun.gupta@nxp.com, jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com To: Hemant Agrawal Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 946E21B644 for ; Tue, 6 Feb 2018 01:05:23 +0100 (CET) In-Reply-To: <20180202134007.qvip4jkiv2gksxoj@platinum> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/02/2018 14:40, Olivier Matz: > On Fri, Feb 02, 2018 at 01:33:01PM +0530, Hemant Agrawal wrote: > > From: Nipun Gupta > > > > The existing rte_eal_mbuf_default mempool ops can return the compile time > > default ops name if the user has not provided command line inputs for > > mempool ops name. It will break the logic of best mempool ops as it will > > never return platform hw mempool ops. > > > > This patch introduces a new API to just return the user mempool ops only. > > > > Fixes: 8b0f7f434132 ("mbuf: maintain user and compile time mempool ops name") > > > > Signed-off-by: Nipun Gupta > > This option is fine for me. I think we may also consider deprecating > rte_eal_mbuf_default_mempool_ops(), as it is done in option 2. > > Acked-by: Olivier Matz Applied, thanks