From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] pmdinfogen: fix resource leak of FILE object
Date: Tue, 06 Feb 2018 01:16:35 +0100
Message-ID: <2667705.0fuXX6fmai@xps>
References: <20180202120058.243184-1-bruce.richardson@intel.com>
 <20180202155112.GB20444@bricha3-MOBL3.ger.corp.intel.com>
 <20180202184721.GC21773@hmswarspite.think-freely.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Neil Horman <nhorman@tuxdriver.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id E0CBC1B3DA
 for <dev@dpdk.org>; Tue,  6 Feb 2018 01:16:39 +0100 (CET)
In-Reply-To: <20180202184721.GC21773@hmswarspite.think-freely.org>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

02/02/2018 19:47, Neil Horman:
> On Fri, Feb 02, 2018 at 03:51:12PM +0000, Bruce Richardson wrote:
> > On Fri, Feb 02, 2018 at 03:47:43PM +0000, Bruce Richardson wrote:
> > > On Fri, Feb 02, 2018 at 07:44:39AM -0500, Neil Horman wrote:
> > > > On Fri, Feb 02, 2018 at 12:00:58PM +0000, Bruce Richardson wrote:
> > > > > Coverity flags an issue where the resources used by the FILE object for
> > > > > the temporary input file are leaked. This is a very minor issue, but is
> > > > > easily fixed, while also avoiding later problems where we try to close
> > > > > an invalid file descriptor in the failure case.
> > > > > 
> > > > > The fix is to use "dup()" to get a new file descriptor number rather than
> > > > > using the value directly from fileno. This allows us to close the file
> > > > > opened with tmpfile() within in scope block, while allowing the duplicate
> > > > > to pass to the outer block and be closed when the function terminates.
> > > > > 
> > > > > As a side-effect I/O in the function is therefore changed from using stdio
> > > > > fread/fwrite to read/write system calls.
> > > > > 
> > > > > Coverity issue: 260399
> > > > > Fixes: 0d68533617e3 ("pmdinfogen: allow using stdin and stdout")
> > > > > 
> > > > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
[...]
> Acked-by: Neil Horman <nhorman@tuxdriver.com>

Applied, thanks