From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3] mbuf: new flag when Vlan is stripped
Date: Wed, 15 Jun 2016 17:20:33 +0200
Message-ID: <26681669.pKzqhz6yqQ@xps13>
References: <1464359593-3534-1-git-send-email-olivier.matz@6wind.com>
 <1465991287-28262-1-git-send-email-olivier.matz@6wind.com>
 <2601191342CEEE43887BDE71AB97725836B71793@irsmsx105.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "johndale@cisco.com" <johndale@cisco.com>, "Zhang,
 Helin" <helin.zhang@intel.com>,
 "adrien.mazarguil@6wind.com" <adrien.mazarguil@6wind.com>,
 "rahul.lakkireddy@chelsio.com" <rahul.lakkireddy@chelsio.com>,
 "alejandro.lucero@netronome.com" <alejandro.lucero@netronome.com>,
 "sony.chacko@qlogic.com" <sony.chacko@qlogic.com>
To: Olivier Matz <olivier.matz@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lb0-f177.google.com (mail-lb0-f177.google.com
 [209.85.217.177]) by dpdk.org (Postfix) with ESMTP id 46ED1C168
 for <dev@dpdk.org>; Wed, 15 Jun 2016 17:20:35 +0200 (CEST)
Received: by mail-lb0-f177.google.com with SMTP id xp5so3534535lbb.0
 for <dev@dpdk.org>; Wed, 15 Jun 2016 08:20:35 -0700 (PDT)
In-Reply-To: <2601191342CEEE43887BDE71AB97725836B71793@irsmsx105.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-06-15 12:33, Ananyev, Konstantin:
> From: Olivier Matz [mailto:olivier.matz@6wind.com]
> > The behavior of PKT_RX_VLAN_PKT was not very well defined, resulting in
> > PMDs not advertising the same flags in similar conditions.
> > 
> > Following discussion in [1], introduce 2 new flags PKT_RX_VLAN_STRIPPED
> > and PKT_RX_QINQ_STRIPPED that are better defined:
> > 
> >   PKT_RX_VLAN_STRIPPED: a vlan has been stripped by the hardware and its
> >   tci is saved in mbuf->vlan_tci. This can only happen if vlan stripping
> >   is enabled in the RX configuration of the PMD.
> > 
> > For now, the old flag PKT_RX_VLAN_PKT is kept but marked as deprecated.
> > It should be removed from applications and PMDs in a future revision.
[...]
> > For PKT_RX_QINQ_PKT, it was only supported on i40e, and the behavior was
> > already correct, so we can reuse the same bit value for
> > PKT_RX_QINQ_STRIPPED.
> > 
> > [1] http://dpdk.org/ml/archives/dev/2016-April/037837.html,
> > 
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> 
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Applied, thanks