From mboxrd@z Thu Jan 1 00:00:00 1970 From: santosh Subject: Re: [PATCH v3 06/11] mempool: remove callback to get capabilities Date: Wed, 4 Apr 2018 20:40:52 +0530 Message-ID: <267dbc9f-0365-cd17-8320-c597a0b4ac74@caviumnetworks.com> References: <1516713372-10572-1-git-send-email-arybchenko@solarflare.com> <1522080591-24705-1-git-send-email-arybchenko@solarflare.com> <1522080591-24705-7-git-send-email-arybchenko@solarflare.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Olivier MATZ , Jerin Jacob To: Andrew Rybchenko , dev@dpdk.org Return-path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0069.outbound.protection.outlook.com [104.47.36.69]) by dpdk.org (Postfix) with ESMTP id 130511C71F for ; Wed, 4 Apr 2018 17:11:14 +0200 (CEST) In-Reply-To: <1522080591-24705-7-git-send-email-arybchenko@solarflare.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Monday 26 March 2018 09:39 PM, Andrew Rybchenko wrote: > The callback was introduced to let generic code to know octeontx > mempool driver requirements to use single physically contiguous > memory chunk to store all objects and align object address to > total object size. Now these requirements are met using a new > callbacks to calculate required memory chunk size and to populate > objects using provided memory chunk. > > These capability flags are not used anywhere else. > > Restricting capabilities to flags is not generic and likely to > be insufficient to describe mempool driver features. If required > in the future, API which returns structured information may be > added. > > Signed-off-by: Andrew Rybchenko > --- Acked-by: Santosh Shukla