From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [RFC PATCH 1/2] ethdev: add function to adjust
	number of descriptors
Date: Mon, 24 Apr 2017 17:13:55 +0200
Message-ID: <2685953.rHhyh0R7Aq@xps>
References: <1488459935-13273-1-git-send-email-arybchenko@solarflare.com>
 <1488459935-13273-2-git-send-email-arybchenko@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
To: Andrew Rybchenko <arybchenko@solarflare.com>, dev@dpdk.org,
 Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 025CA2904
 for <dev@dpdk.org>; Mon, 24 Apr 2017 17:13:56 +0200 (CEST)
In-Reply-To: <1488459935-13273-2-git-send-email-arybchenko@solarflare.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

02/03/2017 14:05, Andrew Rybchenko:
> From: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
> 
> Check that numbers of Rx and Tx descriptors satisfy descriptors limits
> from the Ethernet device information, otherwise adjust them to boundaries.
> 
> Signed-off-by: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>

I think this helper is OK.
We could add it in 17.08.

Is there any comment from PMD maintainers?

[...]
> +static void
> +rte_eth_dev_adjust_nb_desc(uint16_t *nb_desc,
> +			   const struct rte_eth_desc_lim *desc_lim)
> +{
> +	if (desc_lim->nb_align != 0)
> +		*nb_desc = RTE_ALIGN_CEIL(*nb_desc, desc_lim->nb_align);
> +
> +	if (desc_lim->nb_max != 0)
> +		*nb_desc = RTE_MIN(*nb_desc, desc_lim->nb_max);
> +
> +	*nb_desc = RTE_MAX(*nb_desc, desc_lim->nb_min);
> +}
> +
> +int
> +rte_eth_dev_adjust_nb_rx_tx_desc(uint8_t port_id,
> +				 uint16_t *nb_rx_desc,
> +				 uint16_t *nb_tx_desc)
> +{
> +	struct rte_eth_dev *dev;
> +	struct rte_eth_dev_info dev_info;
> +
> +	RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
> +
> +	dev = &rte_eth_devices[port_id];
> +	RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_infos_get, -ENOTSUP);
> +
> +	rte_eth_dev_info_get(port_id, &dev_info);
> +
> +	if (nb_rx_desc != NULL)
> +		rte_eth_dev_adjust_nb_desc(nb_rx_desc, &dev_info.rx_desc_lim);
> +
> +	if (nb_tx_desc != NULL)
> +		rte_eth_dev_adjust_nb_desc(nb_tx_desc, &dev_info.tx_desc_lim);
> +
> +	return 0;
> +}
[...]
> +/**
> + * Check that numbers of Rx and Tx descriptors satisfy descriptors limits from
> + * the ethernet device information, otherwise adjust them to boundaries.
> + *
> + * @param port_id
> + *   The port identifier of the Ethernet device.
> + * @param nb_rx_desc
> + *   A pointer to a uint16_t where the number of receive
> + *   descriptors stored.
> + * @param nb_tx_desc
> + *   A pointer to a uint16_t where the number of transmit
> + *   descriptors stored.
> + * @return
> + *   - (0) if successful.
> + *   - (-ENOTSUP, -ENODEV or -EINVAL) on failure.
> + */
> +int rte_eth_dev_adjust_nb_rx_tx_desc(uint8_t port_id,
> +				     uint16_t *nb_rx_desc,
> +				     uint16_t *nb_tx_desc);
> +