From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-stable] [PATCH] l3fwd-acl: fix unchecked
	return value
Date: Sat, 14 Oct 2017 00:43:32 +0200
Message-ID: <2686354.ZEoe3kJYJj@xps>
References: <1507031282-12469-1-git-send-email-kubax.kozak@intel.com>
 <F6B2DFED41632040B39446096019FF8E0A18BCB9@HASMSX106.ger.corp.intel.com>
 <E182254E98A5DA4EB1E657AC7CB9BD2A8AF2A3D6@BGSMSX101.gar.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: "Yang, Zhiyong" <zhiyong.yang@intel.com>, "Ananyev,
 Konstantin" <konstantin.ananyev@intel.com>, dev@dpdk.org, "Jastrzebski,
 MichalX K" <michalx.k.jastrzebski@intel.com>, "Yigit,
 Ferruh" <ferruh.yigit@intel.com>
To: "Kozak, KubaX" <kubax.kozak@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 0AC201B6FF
 for <dev@dpdk.org>; Sat, 14 Oct 2017 00:43:34 +0200 (CEST)
In-Reply-To: <E182254E98A5DA4EB1E657AC7CB9BD2A8AF2A3D6@BGSMSX101.gar.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

11/10/2017 09:07, Yang, Zhiyong:
> Hi Kuba,
>=20
> Just a soft reminder.  :)=20
> Maintainers will make the decision.
>=20
> Ferruh,  Thomas,
>=20
> Your opinion?

No need to re-send.

More comments:
=2D do not top reply
=2D title should start with examples/
=2D use --in-reply-to when sending a new version

Thanks


> > -----Original Message-----
> > From: Kozak, KubaX
> > Sent: Wednesday, October 11, 2017 2:58 PM
> > To: Yang, Zhiyong <zhiyong.yang@intel.com>; Ananyev, Konstantin
> > <konstantin.ananyev@intel.com>
> > Cc: dev@dpdk.org; stable@dpdk.org; Jastrzebski, MichalX K
> > <michalx.k.jastrzebski@intel.com>
> > Subject: RE: [dpdk-dev] [PATCH] l3fwd-acl: fix unchecked return value
> >=20
> > Thanks Zhiyong,
> >=20
> > Should I correct this patch and resend to dpdk or is it just a suggesti=
on for future?
> >=20
> > Regards,
> > Kuba
> >=20
> > >-----Original Message-----
> > >From: Yang, Zhiyong
> > >Sent: Tuesday, October 10, 2017 08:56
> > >To: Kozak, KubaX <kubax.kozak@intel.com>; Ananyev, Konstantin
> > <konstantin.ananyev@intel.com>
> > >Cc: dev@dpdk.org; Kozak, KubaX <kubax.kozak@intel.com>; stable@dpdk.org
> > >Subject: RE: [dpdk-dev] [PATCH] l3fwd-acl: fix unchecked return value
> > >
> > >Hi=EF=BC=8Ckubax,
> > >
> > >When you form the patch , you should add v2 and changes in v2.
> > >Besides that,  please be free to add
> > >Acked-by: zhiyong yang<zhiyong.yang@intel.com>
> > >
> > >Thanks
> > >Zhiyong
> > >
> > >> -----Original Message-----
> > >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Kuba Kozak
> > >> Sent: Tuesday, October 3, 2017 7:48 PM
> > >> To: Ananyev, Konstantin <konstantin.ananyev@intel.com>
> > >> Cc: dev@dpdk.org; Kozak, KubaX <kubax.kozak@intel.com>;
> > stable@dpdk.org
> > >> Subject: [dpdk-dev] [PATCH] l3fwd-acl: fix unchecked return value
> > >>
> > >> Add return value check and error handling for fseek call.
> > >>
> > >> Coverity issue: 143435
> > >> Fixes: 361b2e9559fc ("acl: new sample l3fwd-acl")
> > >> Cc: konstantin.ananyev@intel.com
> > >> Cc: stable@dpdk.org
> > >>
> > >> Signed-off-by: Kuba Kozak <kubax.kozak@intel.com>
> > >> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> > >> ---
>=20