From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Hunt, David" <david.hunt@intel.com>
Subject: Re: [PATCH v2 2/3] test/power: add unit test for get
	capabilities API
Date: Tue, 26 Jun 2018 10:43:21 +0100
Message-ID: <268d4b8d-0580-0b14-d40e-8e59ff13a73e@intel.com>
References: <1528282041-20380-1-git-send-email-radu.nicolau@intel.com>
 <1528711403-29776-1-git-send-email-radu.nicolau@intel.com>
 <1528711403-29776-2-git-send-email-radu.nicolau@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: chris.macnamara@intel.com, michael.j.glynn@intel.com
To: Radu Nicolau <radu.nicolau@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 43FAD1B4E4
 for <dev@dpdk.org>; Tue, 26 Jun 2018 11:41:44 +0200 (CEST)
In-Reply-To: <1528711403-29776-2-git-send-email-radu.nicolau@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



On 11/6/2018 11:03 AM, Radu Nicolau wrote:
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> ---
>   test/test/test_power_acpi_cpufreq.c | 42 +++++++++++++++++++++++++++++++++++++
>   1 file changed, 42 insertions(+)
>
> diff --git a/test/test/test_power_acpi_cpufreq.c b/test/test/test_power_acpi_cpufreq.c
> index 8da2dcc..67d5ee0 100644
> --- a/test/test/test_power_acpi_cpufreq.c
> +++ b/test/test/test_power_acpi_cpufreq.c
> @@ -18,6 +18,12 @@ test_power_acpi_cpufreq(void)
>   	printf("Power management library not supported, skipping test\n");
>   	return TEST_SKIPPED;
>   }
> +static int
> +test_power_acpi_caps(void)
> +{
> +	printf("Power management library not supported, skipping test\n");
> +	return TEST_SKIPPED;
> +}
>   
>   #else
>   #include <rte_power.h>
> @@ -517,6 +523,42 @@ test_power_acpi_cpufreq(void)
>   	rte_power_unset_env();
>   	return -1;
>   }
> +
> +static int
> +test_power_acpi_caps(void)
> +{
> +	struct rte_power_core_capabilities caps;
> +	int ret;
> +
> +	ret = rte_power_set_env(PM_ENV_ACPI_CPUFREQ);
> +	if (ret) {
> +		printf("Error setting ACPI environment\n");
> +		return -1;
> +	}
> +
> +	ret = rte_power_init(TEST_POWER_LCORE_ID);
> +	if (ret < 0) {
> +		printf("Cannot initialise power management for lcore %u, this "
> +			"may occur if environment is not configured "
> +			"correctly(APCI cpufreq) or operating in another valid "
> +			"Power management environment\n", TEST_POWER_LCORE_ID);
> +		rte_power_unset_env();
> +		return -1;
> +	}
> +
> +	ret = rte_power_get_capabilities(TEST_POWER_LCORE_ID, &caps);
> +	if (ret) {
> +		printf("ACPI: Error getting capabilities\n");
> +		return -1;
> +	}
> +
> +	printf("ACPI: Capabilities %lx\n", caps.capabilities);
> +
> +	rte_power_unset_env();
> +	return 0;
> +}
> +
>   #endif
>   
>   REGISTER_TEST_COMMAND(power_acpi_cpufreq_autotest, test_power_acpi_cpufreq);
> +REGISTER_TEST_COMMAND(power_acpi_caps_autotest, test_power_acpi_caps);

Acked-by: David Hunt<david.hunt@intel.com>