From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v1] app/testpmd: fix Tx first with LSC interrupt Date: Thu, 03 Aug 2017 23:44:03 +0200 Message-ID: <2692805.uYAMR96KvV@xps> References: <1500978472-182803-1-git-send-email-david.hunt@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "De Lara Guarch, Pablo" , "Wu, Jingjing" To: "Hunt, David" Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 37E852C16 for ; Thu, 3 Aug 2017 23:44:06 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > The lsc_interrupt flag is enabled by default, and when the --tx-first is used > > as a command line parameter, the 32 packets can be sent out before the > > link state is up, resulting in the loss of the packets, and no further > > forwarding will take place. > > > > E.g. ./build/app/testpmd -c f0 -- --tx-first --stats-period 1 > > > > When the --tx-first is used, the lsc_interrupt flag needs to be disabled, > > ensuring the links are up before forwarding traffic. Therefore, during the > > parameter checking at startup, if --tx-first is used, we now warn the user, > > and set lsc_interrupt to 0. > > > > Fixes: 99cabef08855 ("app/testpmd: add parameter to start forwarding Tx > > first") > > Signed-off-by: David Hunt > > Acked-by: Pablo de Lara Applied, thanks