From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] ethdev: fix link autonegotiation value
Date: Wed, 10 Jan 2018 20:54:56 +0000
Message-ID: <26941444-afde-3ec6-93f3-48e8d67ad7d5@intel.com>
References: <20180105173855.25473-1-thomas@monjalon.net>
 <20180105124707.602256c5@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Stephen Hemminger <stephen@networkplumber.org>,
 Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 383321B233
 for <dev@dpdk.org>; Wed, 10 Jan 2018 21:54:59 +0100 (CET)
In-Reply-To: <20180105124707.602256c5@xeon-e3>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/5/2018 8:47 PM, Stephen Hemminger wrote:
> On Fri,  5 Jan 2018 18:38:55 +0100
> Thomas Monjalon <thomas@monjalon.net> wrote:
> 
>> There are 3 kind of link data in ethdev:
>> 	- capabilities (rte_eth_dev_info)
>> 	- configuration (rte_eth_conf)
>> 	- status (rte_eth_link)
>>
>> A bit-field is used for capabilities (rte_eth_dev_info.speed_capa) and
>> configuration (rte_eth_conf.link_speeds).
>> Bits are defined in ETH_LINK_SPEED_*.
>>
>> Some numerical (ETH_SPEED_NUM_*) and boolean (ETH_LINK_*) values
>> are used for the link status (rte_eth_link.*).
>>
>> There was a mistake in the comment of rte_eth_link.link_autoneg,
>> suggesting ETH_LINK_SPEED_[AUTONEG/FIXED] which are 0/1,
>> instead of ETH_LINK_[AUTONEG/FIXED] which are 1/0.
>>
>> The drivers are fixed to use ETH_LINK_[AUTONEG/FIXED].
>>
>> Fixes: 82113036e4e5 ("ethdev: redesign link speed config")
>>
>> Suggested-by: Andrew Rybchenko <arybchenko@solarflare.com>
>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> Thanks for clearing this up.
> 
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>

Applied to dpdk-next-net/master, thanks.