From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] devtools: add script to get maintainers from
	patch
Date: Thu, 03 Aug 2017 12:54:00 +0200
Message-ID: <2697465.y20SqaHCPg@xps>
References: <20170428163420.25785-1-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 5D9523257
 for <dev@dpdk.org>; Thu,  3 Aug 2017 12:54:03 +0200 (CEST)
In-Reply-To: <20170428163420.25785-1-ferruh.yigit@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

Sorry for looking at it just now.

28/04/2017 18:34, Ferruh Yigit:
> This is a wrapper to Linux kernel get_maintainer.pl file and only
> supports parsing MAINTAINERS file (no git fallback etc..)

That's the reason the same file format was used in DPDK ;)

> Requires DPDK_GETMAINTAINER_PATH devel config option set, please check
> devtools/load-devel-config.
> 
> DPDK_GETMAINTAINER_PATH should be full patch to the get_maintainer.pl
> script, like:
> DPDK_GETMAINTAINER_PATH=~/linux/scripts/get_maintainer.pl
> 
> Can be used individually:
> ./devtools/get_maintainer.sh <my.patch>
> 
> Or via git send-email, to add maintainers automatically:
> git send-email --to-cmd ./devtools/get_maintainer.sh \
> --cc dev@dpdk.org HEAD -4

Please, could you update the contributor's guide?

> Currently there is an ugly workaround to be able to use Linux script out
> of the kernel tree, later better method can replace it.

Yes it is very ugly :/
Could you try to send a patch to Linux to avoid such workaround?
If we need to keep this workaround, we should at least make sure
the files are always well removed, thanks to a trap invocation.
[...]
> +workaround
> +$DPDK_GETMAINTAINER_PATH $options $@
> +fix_workaround

Please check how trap is used in devtools/test-build.sh
Thanks