From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [dpdk-stable] [PATCH v2] app/testpmd: fix forwarding between non consecutive ports Date: Tue, 07 Nov 2017 21:42:40 +0100 Message-ID: <2698635.jqlqO458xW@xps> References: <1509977954-4333-1-git-send-email-ophirmu@mellanox.com> <1510062750-29091-1-git-send-email-ophirmu@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "De Lara Guarch, Pablo" , "Wu, Jingjing" To: Ophir Munk Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 9546B1B342 for ; Tue, 7 Nov 2017 21:42:42 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 07/11/2017 18:43, De Lara Guarch, Pablo: > From: Ophir Munk > > > > When defining two failsafe devices in testpmd the port numbers of the > > failsafe devices may not be consecutive. > > For example: if failsafe device includes a PCI device and a TAP device then > > failsafe port numbers would be 0 and 3. > > Port 0 - failsafe #1 device > > Port 1 - PCI #1 device > > Port 2 - TAP #1 device > > Port 3 - failsafe #2 device > > Port 4 - PCI #2 device > > Port 5 - TAP #2 device > > > > If forwarding is defined between the failsafe devices including a peer > > address the forwarding should be between peer addresses of ports 0 and 3. > > Instead testpmd establishes forwarding between peer addresses of > > consecutive ports 0 and 1. This commit fixes this bug. > > > > Fixes: af75078fece3 ("first public release") > > Cc: stable@dpdk.org > > > > Signed-off-by: Ophir Munk > > Signed-off-by: Raslan Darawsheh > > Acked-by: Pablo de Lara Applied, thanks