From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] examples: fix unusual-interpreter Date: Mon, 01 Aug 2016 15:26:15 +0200 Message-ID: <2698928.TdmtWMiOju@xps13> References: <1470054511-31217-1-git-send-email-christian.ehrhardt@canonical.com> <2509298.JEBDPBJoPR@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Christian Ehrhardt Return-path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 392645587 for ; Mon, 1 Aug 2016 15:26:18 +0200 (CEST) Received: by mail-wm0-f45.google.com with SMTP id f65so370152110wmi.0 for ; Mon, 01 Aug 2016 06:26:18 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-08-01 15:12, Christian Ehrhardt: > On Mon, Aug 1, 2016 at 2:50 PM, Thomas Monjalon > wrote: > > 2016-08-01 14:28, Christian Ehrhardt: > > > Due to regular lintian checks in Debian packaging it surfaced that these > > > two scripts had a space in their #! statement which renders it to be > > > human, but not shell readable. > > [...] > > > -#! /usr/bin/python2 > > > +#!/usr/bin/python2 > > > > I think we can have a space in the shebang (it works with shells I know). > > But maybe lintian do not like it (and it is a sufficient reason to accept > > this trivial patch). > > > > However, a better fix would be to run something else than python2, > > like /usr/bin/env python. > > > > Some other python scripts in tools dir may be fixed. > > I agree on both changes you suggested, but not being the scripts author I > wanted to change as few as possible. > Also thanks for taking it into consideration even if just for lintian :-) > > If acceptable to you I'd ask to accept this as-is and consider the patch a > head-up for all script owners to change their headers. We can remove the space in every scripts, at least. Then we can wait a little for the opinion of the script authors to do more changes. PS: Please avoid top posting.