From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3] ethdev: cleanup device ops struct
 whitespace
Date: Thu, 22 Dec 2016 15:16:40 +0000
Message-ID: <26b1177f-93c3-d3c3-fa63-e971af8dd139@intel.com>
References: <20161222115330.7164-1-ferruh.yigit@intel.com>
 <20161222131013.28516-1-ferruh.yigit@intel.com>
 <CALe+Z02WKE7rBvqt8ygHwnWv-OLcxqe5Uf+GSmhJMrTskL57BA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jan Blunck <jblunck@infradead.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 1B1B510D8F
 for <dev@dpdk.org>; Thu, 22 Dec 2016 16:16:43 +0100 (CET)
In-Reply-To: <CALe+Z02WKE7rBvqt8ygHwnWv-OLcxqe5Uf+GSmhJMrTskL57BA@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/22/2016 3:10 PM, Jan Blunck wrote:
> On Thu, Dec 22, 2016 at 2:10 PM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>> - Grouped related items using empty lines
> 
> Reordering fields of a struct is breaking ABI. We should bump the
> library version now.

You are right, sorry missed that.
Intention was not to break the ABI, but cleanup.

Thomas,
If it is too late, do you want me prepare a revert patch?

> 
> 
>> - Aligned arguments to same column
>> - All item comments that doesn't fit same line are placed blow the item
>>   itself
>> - Moved some comments to same line if overall line < 100 chars
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>
<...>