From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH 6/7] vmxnet3: introduce command to register
 memory region
Date: Fri, 3 Mar 2017 10:46:25 +0000
Message-ID: <26cbffea-5ccd-a2b1-346b-dca6fea9c141@intel.com>
References: <1488059989-6930-1-git-send-email-skhare@vmware.com>
 <1488059989-6930-7-git-send-email-skhare@vmware.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Guolin Yang <gyang@vmware.com>
To: Shrikrishna Khare <skhare@vmware.com>, yongwang@vmware.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 60D8E6787
 for <dev@dpdk.org>; Fri,  3 Mar 2017 11:46:31 +0100 (CET)
In-Reply-To: <1488059989-6930-7-git-send-email-skhare@vmware.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2/25/2017 9:59 PM, Shrikrishna Khare wrote:
> In vmxnet3 version 3, the emulation added support for the vmxnet3 driver
> to communicate information about the memory regions the driver will use
> for rx/tx buffers. The driver can also indicate which rx/tx queue the
> memory region is applicable for. If this information is communicated
> to the emulation, the emulation will always keep these memory regions
> mapped, thereby avoiding the mapping/unmapping overhead for every packet.
> 
> Signed-off-by: Shrikrishna Khare <skhare@vmware.com>
> Signed-off-by: Guolin Yang <gyang@vmware.com>
> Acked-by: Yong Wang <yongwang@vmware.com>
> Acked-by: Jin Heo <heoj@vmware.com>

<...>

> +		PMD_INIT_LOG(INFO,
> +			     "index: %u startPA: %lu  length: %u, rxBits: %x",
> +			     j, mr->startPA, mr->length, mr->rxQueueBits);
> +		j++;
> +	}
> +	hw->memRegs->numRegs = j;
> +	PMD_INIT_LOG("numRegs: %u", j);

Macro argument is not correct, causing following build error:

.../drivers/net/vmxnet3/vmxnet3_ethdev.c:568:2: error: pasting formed
'RTE_LOG_"numRegs: %u"', an invalid preprocessing token
        PMD_INIT_LOG("numRegs: %u", j);
        ^