From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kyle Larose Subject: Re: [PATCH] bus/vdev: scan and probe vdev in secondary processes Date: Thu, 30 Nov 2017 22:27:28 +0000 Message-ID: <26d38eefe9814bfcb29b058b8922dc8c@sandvine.com> References: <1512068332-98288-1-git-send-email-jianfeng.tan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: Matthew Coppola To: Jianfeng Tan , "dev@dpdk.org" Return-path: Received: from mail1.sandvine.com (Mail1.sandvine.com [64.7.137.134]) by dpdk.org (Postfix) with ESMTP id 127FB1B199 for ; Thu, 30 Nov 2017 23:27:29 +0100 (CET) In-Reply-To: <1512068332-98288-1-git-send-email-jianfeng.tan@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hey Jianfeng, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jianfeng Tan > Sent: Thursday, November 30, 2017 1:59 PM > To: dev@dpdk.org > Cc: Jianfeng Tan > Subject: [dpdk-dev] [PATCH] bus/vdev: scan and probe vdev in > secondary processes >=20 > Base on primary/secondary communication channel [1], we add vdev > action to scan virtual devices in secondary processes. >=20 > [1] http://dpdk.org/dev/patchwork/patch/31838/ >=20 > Signed-off-by: Jianfeng Tan > --- > drivers/bus/vdev/vdev.c | 104 > ++++++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 100 insertions(+), 4 deletions(-) >=20 We recently stumbled across a problem where running dpdk-pdump against a primary which had an rte_eth_bond virtual device would lead to a crash. We realized this was happening because the vdev bus wasn't being built properly on the secondary, leading to it corrupting the ethdev structures for the eth_bond device on the primary. This corruption occurred because pd= ump used what it thought was the first free dpdk port id for its pcap_pmd. That= =20 port id collided with the eth_bond pmd, causing the problem. My feeling is that this patch will fix that problem, since probing the virt= ual bus from the primary, rather than just from the eal cmdline arguments, will= =20 allow the secondary to choose an used port id. Am I correct in my understan= ding? Thanks, Kyle