From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] mk: fix verbosity zero
Date: Fri, 23 Sep 2016 11:30:36 +0200
Message-ID: <2710503.PVzG3DrFxT@xps13>
References: <6873211.QDWnoOkD9j@xps13>
 <1474587767-20033-1-git-send-email-thomas.monjalon@6wind.com>
 <b0e9c72b-4987-58de-4ae3-fa8a7546c0aa@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42])
 by dpdk.org (Postfix) with ESMTP id 9AB84569F
 for <dev@dpdk.org>; Fri, 23 Sep 2016 11:30:39 +0200 (CEST)
Received: by mail-wm0-f42.google.com with SMTP id w84so19983480wmg.1
 for <dev@dpdk.org>; Fri, 23 Sep 2016 02:30:39 -0700 (PDT)
In-Reply-To: <b0e9c72b-4987-58de-4ae3-fa8a7546c0aa@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-09-23 10:06, Ferruh Yigit:
> On 9/23/2016 12:42 AM, Thomas Monjalon wrote:
> > Verbosity is considered enabled when $V is not empty.
> > So V=0 and V=1 are equivalent.
> > It is fixed by unsetting V when it is 0.
> > 
> > A side effect is to fix kernel module compilation verbosity
> > which is set to 0 when V is empty.
> > 
> > Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
[...]
> > --- a/mk/rte.sdkroot.mk
> > +++ b/mk/rte.sdkroot.mk
> > @@ -34,6 +34,9 @@ MAKEFLAGS += --no-print-directory
> >  # define Q to '@' or not. $(Q) is used to prefix all shell commands to
> >  # be executed silently.
> >  Q=@
> > +ifeq '$V' '0'
> > +override V=
> > +endif
> >  ifdef V
> 
> Why not simply:
> -ifdef V
> +ifeq ($(V),1)

Because:
- V could have a higher value
- $(if $V) construct is used in several places in the makefiles
	See git grep '$(if $(*V'