From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 2/2] mk: move PMD libraries to applications Date: Tue, 31 Jan 2017 15:16:19 +0100 Message-ID: <2710569.WpYSWQ2PKI@xps13> References: <20170131121427.31279-1-ferruh.yigit@intel.com> <20170131121427.31279-2-ferruh.yigit@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Ferruh Yigit Return-path: Received: from mail-wj0-f172.google.com (mail-wj0-f172.google.com [209.85.210.172]) by dpdk.org (Postfix) with ESMTP id D6E22282 for ; Tue, 31 Jan 2017 15:16:21 +0100 (CET) Received: by mail-wj0-f172.google.com with SMTP id b20so14592055wjs.2 for ; Tue, 31 Jan 2017 06:16:21 -0800 (PST) In-Reply-To: <20170131121427.31279-2-ferruh.yigit@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-01-31 12:14, Ferruh Yigit: > Same PMDs provide device specific APIs. Bond and xenvirt are existing > samples for this. s/Same/Some/ > And since these are PMD libraries, there are two options on how to link > them. > > 1- They can be fully included to all applications, using common > rte.app.mk file by default. > > 2- They can be explicitly linked to applications that use device > specific API. > > Currently option one is in use, this patch switches to the option two. > > Moves library linking to the application of Makefile that uses device > specific API. > > This prevent including these libraries into final applications that > don't use these device specific APIs. That's an interesting point of view. What about the other libraries automatically linked in rte.app.mk? Could we make each application decide which library they want to be linked with?