From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] pci/vfio: fixup
	rte_intr_callback_unregister() handling
Date: Mon, 29 Oct 2018 01:10:28 +0100
Message-ID: <2717848.8FJ2b4WWs2@xps>
References: <20181024101131.17756-1-dariusz.stojaczyk@intel.com>
 <0e6afdfc-2dfa-a9c2-068d-9fe424de0779@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>,
 jia.guo@intel.com
To: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id DA54D2BB1
 for <dev@dpdk.org>; Mon, 29 Oct 2018 01:10:24 +0100 (CET)
In-Reply-To: <0e6afdfc-2dfa-a9c2-068d-9fe424de0779@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

26/10/2018 16:23, Burakov, Anatoly:
> On 24-Oct-18 11:11 AM, Darek Stojaczyk wrote:
> > This function is documented to return the number of unregistered
> > callbacks or negative numbers on error, but pci_vfio checks for
> > ret != 0 to detect failures. Not anymore.
> > 
> > Fixes: c115fd000c32 ("vfio: handle hotplug request notifier")
> > Cc: jia.guo@intel.com
> > Cc: stable@dpdk.org

No need for stable backport here.

> > Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
> 
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

Applied, thanks