From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v4 09/11] eal: replace rte_panic instances in
	ethdev
Date: Fri, 20 Apr 2018 15:56:56 +0200
Message-ID: <2727458.a5P0WfqTky@xps>
References: <1524117669-25729-1-git-send-email-arnon@qwilt.com>
 <f307c97a-58f2-9919-9e1b-5afde681444d@redhat.com>
 <CAKy9EB1p9tHdCON3JHkShBaduN=Y+_wuZdh2AVvaOgdREpRc4Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>, "Lu,
 Wenzhuo" <wenzhuo.lu@intel.com>, "Doherty, Declan" <declan.doherty@intel.com>,
 jerin.jacob@caviumnetworks.com, Bruce Richardson <bruce.richardson@intel.com>,
 "Yigit, Ferruh" <ferruh.yigit@intel.com>
To: Arnon Warshavsky <arnon@qwilt.com>, Kevin Traynor <ktraynor@redhat.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 1F87F7EE4
 for <dev@dpdk.org>; Fri, 20 Apr 2018 15:56:59 +0200 (CEST)
In-Reply-To: <CAKy9EB1p9tHdCON3JHkShBaduN=Y+_wuZdh2AVvaOgdREpRc4Q@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

20/04/2018 15:23, Arnon Warshavsky:
> >
> > Lots of "!= 0"'s - you might gather by now that I don't like them :-)
> >
> 
> No way. Would have never guessed that :)
> Sure. When in Rome..

It is a matter of taste. I like the explicit "!= 0".
At least, explicit NULL comparisons are recommended in the coding style:
	http://dpdk.org/doc/guides/contributing/coding_style.html#null-pointers
For boolean return, it is OK to be implicit.
But for error codes, I think it is better to be explicit.
Again, matter of taste.

By the way, looking at "git grep 'if (rte_'" suggests it is common.