From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] i40e: Fix the endian issue for the i40e
	read&write registers functions
Date: Tue, 14 Jul 2015 22:03:53 +0200
Message-ID: <2728205.CWfvQXyGGP@xps13>
References: <1436870216-12926-1-git-send-email-zhe.tao@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Zhe Tao <zhe.tao@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42])
 by dpdk.org (Postfix) with ESMTP id AD822E72
 for <dev@dpdk.org>; Tue, 14 Jul 2015 22:05:05 +0200 (CEST)
Received: by wgxm20 with SMTP id m20so17148495wgx.3
 for <dev@dpdk.org>; Tue, 14 Jul 2015 13:05:05 -0700 (PDT)
In-Reply-To: <1436870216-12926-1-git-send-email-zhe.tao@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-07-14 18:36, Zhe Tao:
> Linux kernel uses the writel and readl related functions to perform the PCI memory access via ioremap region,
> those functions will handle the big little endian properly by doing the conversion between little and big endian if necessary,
> so Add this conversion in the read&write registers functions for i40e.

You compare with the Linux implementation but you forget to describe
the problem which would be a better justification.