From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-stable] [PATCH] eal: fix build of external
	apps with clang on armv8
Date: Mon, 14 Jan 2019 20:06:04 +0100
Message-ID: <2738048.OSRjOPMpyn@xps>
References: <CGME20190114161447eucas1p1c1d73ede17b706e69a4db491f8c94578@eucas1p1.samsung.com>
 <2566607.iMXo4xvV1S@xps> <3867865.yVi6bGp0KD@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Ilya Maximets <i.maximets@samsung.com>, stable@dpdk.org,
 Pavan Nikhilesh <pbhagavatula@marvell.com>, honnappa.nagarahalli@arm.com
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <3867865.yVi6bGp0KD@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

14/01/2019 19:49, Thomas Monjalon:
> 14/01/2019 17:27, Thomas Monjalon:
> > 14/01/2019 17:14, Ilya Maximets:
> > > In case DPDK built using GCC, RTE_TOOLCHAIN_CLANG is not defined.
> > > But 'rte_atomic.h' is a generic header that included to the
> > > external apps like OVS while building with DPDK. As a result,
> > > clang build of OVS fails on ARMv8 if DPDK built using gcc:
> > > 
> > >     include/generic/rte_atomic.h:215:9: error:
> > >             implicit declaration of function '__atomic_exchange_2'
> > >             is invalid in C99
> > >     include/generic/rte_atomic.h:494:9: error:
> > >             implicit declaration of function '__atomic_exchange_4'
> > >             is invalid in C99
> > >     include/generic/rte_atomic.h:772:9: error:
> > >             implicit declaration of function '__atomic_exchange_8'
> > >             is invalid in C99
> > > 
> > > We need to check for current compiler, not the compiler used for
> > > DPDK build.
> > 
> > Right, API cannot rely on internal build system configuration.
> > 
> > > Fixes: 7bdccb93078e ("eal: fix ARM build with clang")
> > > Cc: stable@dpdk.org
> > > 
> > > Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
> > 
> > Acked-by: Thomas Monjalon <thomas@monjalon.net>
> 
> Applied (if armv8 typo), thanks

correction: with armv8 typo fixed