From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v4 4/5] eal: add per rx queue interrupt
	handling based on VFIO
Date: Mon, 23 Feb 2015 16:19:15 +0100
Message-ID: <2740446.fpxNnYhYZp@xps13>
References: <1424353698-29837-1-git-send-email-danny.zhou@intel.com>
 <3509738.2W4po8ncMD@xps13>
 <DFDF335405C17848924A094BC35766CF0AAB3C60@SHSMSX104.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: "Zhou, Danny" <danny.zhou-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <DFDF335405C17848924A094BC35766CF0AAB3C60-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2015-02-23 15:02, Zhou, Danny:
> From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]
> > 2015-02-23 11:47, Zhou, Danny:
> > > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]
> > > > 2015-02-19 21:48, Zhou Danny:
> > > > > --- a/lib/librte_eal/linuxapp/eal/Makefile
> > > > > +++ b/lib/librte_eal/linuxapp/eal/Makefile
> > > > > @@ -43,6 +43,7 @@ CFLAGS += -I$(SRCDIR)/include
> > > > >  CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common
> > > > >  CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common/include
> > > > >  CFLAGS += -I$(RTE_SDK)/lib/librte_ring
> > > > > +CFLAGS += -I$(RTE_SDK)/lib/librte_mbuf
> > > > >  CFLAGS += -I$(RTE_SDK)/lib/librte_mempool
> > > > >  CFLAGS += -I$(RTE_SDK)/lib/librte_malloc
> > > > >  CFLAGS += -I$(RTE_SDK)/lib/librte_ether
> > > >
> > > > Why do we need mbuf in EAL?
> > >
> > > The file eal_interrupts.c includes rte_ethdev.h which defines structure rte_eth_devices that
> > > eal needs to use in order to get per-port intr_handle. The rte_ethdev.h includes the rte_mbuf.h
> > > so the Makefile is updated here.
> > 
> > I see. You are breaking layer isolation by introducing ethdev in EAL.
> > The cause seems to be:
> > 
> > +       struct rte_intr_handle intr_handle =
> > +                               rte_eth_devices[port_id].pci_dev->intr_handle;
> > 
> > Maybe that pci_dev should be a parameter of the function.
> 
> Adding pci_dev as a parameter has similar problem due to eal does not include rte_pci.h which

I don't understand your assertion. rte_pci.h is part of EAL.

> defines struct rte_pci_device. It looks the new-added function rte_eal_wait_rx_intr(uint8_t port_id, uint8_t queue_id);
> is not proper to be declared in rte_eal.h, will rename it to 
> 	rte_intr_wait_rx (struct rte_intr_handle *intr_handle, uint8_t queue_id);
> 
> and then move declaration from rte_eal.h to rte_interrupts.h. So isolation can be avoided and no need to includes rte_ethdev.h
> and change Makefile.

Yes could be better.