From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2 3/6] examples/ipsec-secgw: fix aad_len for
	for aes-gcm
Date: Fri, 20 Oct 2017 12:52:56 +0200
Message-ID: <2754764.nFg3Fio5kK@xps>
References: <1507987683-12315-1-git-send-email-aviadye@dev.mellanox.co.il>
 <1508439184-17893-3-git-send-email-aviadye@dev.mellanox.co.il>
 <E115CCD9D858EF4F90C690B0DCB4D8976CC38599@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, dev@dpdk.org,
 "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>,
 "borisp@mellanox.com" <borisp@mellanox.com>,
 "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
 "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "Nicolau,
 Radu" <radu.nicolau@intel.com>, "Doherty, Declan" <declan.doherty@intel.com>,
 "liranl@mellanox.com" <liranl@mellanox.com>,
 "nelio.laranjeiro@6wind.com" <nelio.laranjeiro@6wind.com>
To: "aviadye@dev.mellanox.co.il" <aviadye@dev.mellanox.co.il>,
 "aviadye@mellanox.com" <aviadye@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 2220F1B20A
 for <dev@dpdk.org>; Fri, 20 Oct 2017 12:52:58 +0200 (CEST)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CC38599@IRSMSX108.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

20/10/2017 11:52, De Lara Guarch, Pablo:
> Same comments as in patch 1, and also fix the commit title
> ("for" duplicated) and avoid "_".

The underscore is forbidden in titles to avoid naming variable or
function names instead of giving a clear scope understandable
without digging in the code.
Here "aad_len" can probably be replaced by "AAD length".