From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 2/2] eal: pci probe and adjust_config should be void Date: Mon, 20 Apr 2015 15:14:15 +0200 Message-ID: <2757566.zEsJEgcNg7@xps13> References: <1429284934-3261-1-git-send-email-stephen@networkplumber.org> <1429284934-3261-3-git-send-email-stephen@networkplumber.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Stephen Hemminger Return-path: In-Reply-To: <1429284934-3261-3-git-send-email-stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2015-04-17 08:35, Stephen Hemminger: > This functions always returned 0 and therefore should be void. > > Signed-off-by: Stephen Hemminger > --- > lib/librte_eal/common/eal_common_options.c | 3 +-- > lib/librte_eal/common/eal_common_pci.c | 7 ++----- > lib/librte_eal/common/eal_options.h | 2 +- > lib/librte_eal/common/include/rte_pci.h | 6 +----- > lib/librte_eal/linuxapp/eal/eal.c | 6 ++---- > 5 files changed, 7 insertions(+), 17 deletions(-) Why bsdapp is not changed? You posted a similar patch few days before which was modifying bsdapp: http://dpdk.org/dev/patchwork/patch/4306/