From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] kni: fix missing backslash in Makefile
Date: Fri, 01 Aug 2014 21:28:53 +0200
Message-ID: <2764645.XhU1T6HqyO@xps13>
References: <1406912161-5659-1-git-send-email-julien.cretin@trust-in-soft.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Julien Cretin <julien.cretin-5/pgmGDL2QNYvNUnsyAbJwC/G2K4zDHf@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1406912161-5659-1-git-send-email-julien.cretin-5/pgmGDL2QNYvNUnsyAbJwC/G2K4zDHf@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi Julien,

2014-08-01 18:56, Julien Cretin:
> With GNU Make 3.81 on Ubuntu 14.04, I get:
> lib/librte_eal/linuxapp/kni/Makefile:49: *** unterminated call to function `shell': missing `)'.  Stop.
> 
> Signed-off-by: Julien Cretin <julien.cretin-5/pgmGDL2QNYvNUnsyAbJwC/G2K4zDHf@public.gmane.org>

> -UBUNTU_KERNEL_CODE := $(shell cut -d' ' -f2 /proc/version_signature |
> +UBUNTU_KERNEL_CODE := $(shell cut -d' ' -f2 /proc/version_signature | \
>                          cut -d- -f1,2 | tr .- $(comma))

My fault, I forgot the backslash when splitting line.

Acked-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>

Applied.

Thanks for the quick test and report.
-- 
Thomas