From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] mem: remove old function from symbol list
Date: Fri, 03 Nov 2017 14:52:26 +0100
Message-ID: <2774584.OjYm9LEu22@xps>
References: <20171103112455.18406-1-thomas@monjalon.net>
 <173a41cb-53b7-b986-bdaa-d36676c4d740@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: jianfeng.tan@intel.com, dev@dpdk.org, bluca@debian.org
To: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id A6D8B7D06
 for <dev@dpdk.org>; Fri,  3 Nov 2017 14:52:28 +0100 (CET)
In-Reply-To: <173a41cb-53b7-b986-bdaa-d36676c4d740@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

03/11/2017 12:34, Gonzalez Monroy, Sergio:
> Hi Thomas,
> 
> I reckon you need to bump ABI version when you remove public symbol from 
> .map file.

Yes, of course, unless it has already been dumped:
	http://dpdk.org/commit/f26ab687a74


> On 03/11/2017 11:24, Thomas Monjalon wrote:
> > The function rte_mem_phy2mch() was removed with the support
> > of Xen dom0.
> >
> > Fixes: a7cb2e20d23c ("mem: remove API to get physical address in dom0")
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> >   lib/librte_eal/rte_eal_version.map | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
> > index d2a4ff974..7c9bdc2ae 100644
> > --- a/lib/librte_eal/rte_eal_version.map
> > +++ b/lib/librte_eal/rte_eal_version.map
> > @@ -62,7 +62,6 @@ DPDK_2.0 {
> >   	rte_malloc_validate;
> >   	rte_malloc_virt2phy;
> >   	rte_mem_lock_page;
> > -	rte_mem_phy2mch;
> >   	rte_mem_virt2phy;
> >   	rte_memdump;
> >   	rte_memory_get_nchannel;
> 
>