From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v5 00/21] Fixes for GCC8 against lagopus Date: Mon, 21 May 2018 00:18:56 +0200 Message-ID: <2776412.uDdhf0LMkq@xps> References: <152627436523.53156.4398253089110011263.stgit@localhost.localdomain> <152656480225.46638.3271983577765861155.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Andy Green Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 26B348E58 for ; Mon, 21 May 2018 00:18:59 +0200 (CEST) In-Reply-To: <152656480225.46638.3271983577765861155.stgit@localhost.localdomain> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Andy Green (21): > lib/librte_ethdev: change eth-dev-ops API to return int > rte_string_fns.h: fix gcc8.1 sign conv warning in lstrcpy > lib/librte_eal: explicit tmp cast > /lib/librte_eal: stage cast from uint64 to long > rte_ring_generic.h: stack declarations before code > rte_ring.h: remove signed type flipflopping > rte_mbuf.h: avoid warnings from inadvertant promotion > rte_mbuf.h: explicit casts for int16 to uint16 > rte_mbuf.h: make sure RTE-MIN compares same types > rte_mbuf.h: explicit cast restricting ptrdiff to uint16 > rte_ether.h: explicit cast avoiding truncation warning > rte_rwlock.h: gcc8 sign conversion warnings > rte_ip.h: cast input to bswap16 to be uint16 > rte_ip.h: cast around promotion to int > rte_ip.h: cast type decided by sizeof to uint32 > rte_ip.h: cast return checksum size to uint16 > rte_ip.h: cast away gcc8 warning on rte_ipv6_phdr_cksum > rte_mbuf.h: explicit cast for size type to uint32 > rte_mbuf.h: explicit casts to uint16 to avoid warnings > rte_ethdev.h: align sign and scope of temp var > rte_byteorder.h: explicit cast for return promotion 16 patches have been applied. The tags Fixes and Cc:stable have been added, so they can be backported. 5 patches are missing: lib/librte_eal: explicit tmp cast rte_rwlock.h: gcc8 sign conversion warnings rte_ip.h: cast type decided by sizeof to uint32 rte_mbuf.h: explicit casts to uint16 to avoid warnings rte_ethdev.h: align sign and scope of temp var Those patches are either not reviewed, or not safe enough at this release stage. Please, feel free to send them again in a v6 to make clear they need more review. I think the mbuf one (for uint16_t) may deserve to be split. Thanks